chore(chain)!: use debug_assert! on apply_update
#1734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in issue bitcoindevkit#1689 the `debug_assert!` is being used on other `LocalChain` methods, such as: `from_changeset`, and `apply_changeset` but it was missing on `apply_update`.
ValuedMammal
approved these changes
Nov 20, 2024
Collaborator
ValuedMammal
left a comment
ValuedMammal
left a comment
There was a problem hiding this comment.
ACK 2ec5aa4 Thank you @oleonardolima
notmandatory
added
module-blockchain
audit
Member
|
oops I closed the wrong PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1689
Description
As mentioned in issue #1689 the
debug_assert!is being used on otherLocalChainmethods, such as:from_changeset, andapply_changesetbut it was missing onapply_update.Notes to the reviewers
Changelog notice
debug_assert!()toLocalChain::apply_update.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: